-
-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shuffle Service #5976
Closed
Closed
Shuffle Service #5976
Changes from all commits
Commits
Show all changes
101 commits
Select commit
Hold shift + click to select a range
9deb8c6
Move pandas groupby outside of event loop
mrocklin 3f62911
Add MultiFile prototype
mrocklin 626eda0
Integrate MultiFile with shuffle extension
mrocklin 7f48f77
Add buffered comms
mrocklin 99bb283
Move multi files to shuffle/
mrocklin 0d49ab9
add arrow
mrocklin 1e1311d
Handle buffers manually in multi_file
mrocklin b99329a
Pass around only bytes
mrocklin 5781b7e
Clean up a few extra copies
mrocklin 0ce6e01
Let comms continue without blocking on disk
mrocklin 3204997
Move flush into multi_file.read
mrocklin 8b11d6d
Avoid multiple accesses to the same file
mrocklin 62cc43d
Change configuration for smoother single-machine use
mrocklin 5a64248
Fix up some concurrency issues
mrocklin b901613
Fix shard size accountiing
mrocklin 24092bb
add more connections if more workers
mrocklin 7fbe4aa
Allow worker extensions to piggy-back on heartbeat
mrocklin 89f6347
Merge branch 'heartbeat-extensions' into p2p-shuffle
mrocklin bc81db8
Remove file cache
mrocklin 27d2ab3
First pass on adding a Scheduler extension and worker heartbeat
mrocklin 9fd6da0
Name scheduler extensions
mrocklin 8641abb
Merge branch 'heartbeat-extensions' into p2p-shuffle
mrocklin 34617db
fixup test
mrocklin e1c0a4d
Add timing and diagnostics
mrocklin 8c28b83
fixup tests
mrocklin 29253b4
Use names for client extensions
mrocklin 1f79575
Add back in manual addition of stealing extension
mrocklin cf9a939
Merge branch 'heartbeat-extensions' into p2p-shuffle
mrocklin 6f2286e
Add basic shuffling dashboard
mrocklin efedc04
Merge branch 'main' of github.com:dask/distributed into heartbeat-ext…
mrocklin 9b7b03b
Merge branch 'heartbeat-extensions' into p2p-shuffle
mrocklin 456de23
Add colors to shuffling plots
mrocklin aef2f61
make larger dashboard page
mrocklin f79e923
extend shuffling dashboard
mrocklin 1e0256f
Don't offload file writes
mrocklin 97fb09c
reduce comm memory limit
mrocklin 76baf4b
Merge branch 'main' into heartbeat-extensions
mrocklin f58b2e9
use multi-threaded thread-pool and swap np.unique for pd.Series.unique
mrocklin 9bc6ce6
removeme: check state of extensions in test
mrocklin 57b4a42
Merge branch 'heartbeat-extensions' of github.com:mrocklin/distribute…
mrocklin 1309c22
I think that there is some strange SchedulerState interation going on
mrocklin c894f40
Track Event Loop intervals in dashboard plot
mrocklin 486320d
Grey out unseen workers
mrocklin 6419328
flake8
mrocklin 9e6aadc
remove old test
mrocklin c202385
Merge branch 'main' of github.com:dask/distributed into p2p-shuffle
mrocklin cf51784
Merge branch 'event-loop-dashboard' into p2p-shuffle
mrocklin c272458
bump y-axis, add kwargs
mrocklin 1d114c2
Merge branch 'event-loop-dashboard' into p2p-shuffle
mrocklin 4ba9923
Add event loop figure to shuffling page
mrocklin e7a5143
Remove errant print
mrocklin b0cd7ae
Add test for the compute chain
mrocklin bd37f49
Simplify MultiComm and add docstrings
mrocklin 6e1af62
Add close method to extensions
mrocklin 7776ecb
Merge branch 'heartbeat-extensions' into p2p-shuffle
mrocklin 107b5a0
Add close method to ShuffleWorkerExtension
mrocklin dc8a7a4
clean up old methods
mrocklin 6ef62a0
Move multi-shuffle state to class level
mrocklin 8550a13
Speed up tests
mrocklin 2e01aa8
move multicomm queue to class level
mrocklin 4486584
add docstrings and cleanup communicate future
mrocklin 01403b9
Update distributed/stealing.py
mrocklin 97fdf2a
use nonlocal
mrocklin 0bd1f89
Merge branch 'heartbeat-extensions' of github.com:mrocklin/distribute…
mrocklin 182dc83
Merge branch 'main' of github.com:dask/distributed into heartbeat-ext…
mrocklin 007ea90
Update distributed/shuffle/multi_file.py
mrocklin d27d0f3
Merge branch 'main' of github.com:dask/distributed into heartbeat-ext…
mrocklin b50c61a
Merge branch 'heartbeat-extensions' into p2p-shuffle
mrocklin dfc31fd
Merge branch 'p2p-shuffle' of github.com:mrocklin/distributed into p2…
mrocklin ea000a3
cleanup hover
mrocklin 4598577
Use weakkeydicitonary to handle multiple queues
mrocklin 2993643
Add total_size to class level
mrocklin fe61116
make dashboard robust to missing workers
mrocklin adccb02
tests pass
mrocklin 3aabef0
depend on pyarrow in CI
mrocklin 2af4974
install dask@p2p-shuffle
mrocklin 1756fb2
simplify dashboard charts
mrocklin 6694c84
Move arrow utilities over to a separate file
mrocklin 154b21f
Merge branch 'main' of github.com:dask/distributed into p2p-shuffle
mrocklin 36956ef
Merge branch 'main' of github.com:dask/distributed into p2p-shuffle
mrocklin 2ab401a
make multi_file tests pass
mrocklin 90673d1
Add test for MultiComm
mrocklin 7d8954a
Respond to feedback
mrocklin 1796804
Drop runtime dependency to setuptools (#6017)
crusaderky 8de2793
More idiomatic mypy configuration (#6022)
crusaderky caa852f
Python 3.10 (#5952)
graingert f3fb682
Cluster Dump SchedulerPlugin (#5983)
sjperkins 0a1761d
Add tiny test for ToPickle (#6021)
mrocklin 7cdb56f
Update gpuCI `RAPIDS_VER` to `22.06` (#5962)
github-actions[bot] d0afbb1
Retry on transient error codes in preload (#5982)
mrocklin a74fd38
Remove support for PyPy (#6029)
jrbourbeau bde718f
Make test_reconnect async (#6000)
mrocklin dd857b8
Short variant of test_report.html (#6034)
crusaderky 9efb27c
Add test for bad disk
mrocklin 69bed31
Support exceptions in MultiComm
mrocklin ec71091
add unit tests for exceptions
mrocklin 016ed25
cleanup files properly
mrocklin 8ee5605
cleanup extra futures
mrocklin 1c3bfb9
Merge branch 'main' of github.com:dask/distributed into p2p-shuffle
mrocklin fa235ee
Support windows in tests (hopefully)
mrocklin df4348f
Merge branch 'main' of github.com:dask/distributed into p2p-shuffle
mrocklin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -49,3 +49,4 @@ repos: | |
- dask | ||
- tornado | ||
- zict | ||
- pyarrow |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this already in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet: dask/dask#8836