Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should follow same-origin redirects #25

Open
da2x opened this issue Dec 12, 2019 · 2 comments · May be fixed by #29
Open

Should follow same-origin redirects #25

da2x opened this issue Dec 12, 2019 · 2 comments · May be fixed by #29

Comments

@da2x
Copy link
Contributor

da2x commented Dec 12, 2019

https://staltz.com/.well-known/dat redirects to https://staltz.com/dat which returns a 200 status code and a Dat-DNS file in the expected format. dat-dns treats the redirect as a failure so @staltz’s homepage won’t load in Beaker, however.

dat-dns should follow same-origin (same scheme, domain, and port) redirects. Cross-origin redirects may have security implications. Same-origin redirects should be safe, however.
@staltz
Copy link

staltz commented Dec 13, 2019

So that's why it hasn't worked! Thanks for debugging

@RangerMauve
Copy link
Collaborator

A PR for this would probably be welcome. 😁

da2x added a commit to da2x/dat-dns that referenced this issue Mar 25, 2020
@da2x
Add redirect support (limit: 6)
55a3fb8 
Resolves issue dat-ecosystem-archive#25.
@da2x da2x mentioned this issue Mar 25, 2020
Open
martinheidegger pushed a commit that referenced this issue Mar 26, 2021
@da2x @martinheidegger
Add redirect support (limit: 6)
b3e5ba5 
Resolves issue #25.
martinheidegger pushed a commit that referenced this issue Mar 26, 2021
@da2x @martinheidegger
Add redirect support (limit: 6)
6fa51f8 
Resolves issue #25.
martinheidegger pushed a commit that referenced this issue Mar 26, 2021
@da2x @martinheidegger
Add redirect support (limit: 6)
b2e5cfe 
Resolves issue #25.
martinheidegger pushed a commit that referenced this issue Mar 26, 2021
@da2x @martinheidegger
Add redirect support (limit: 6)
618d530 
Resolves issue #25.
@martinheidegger martinheidegger linked a pull request Mar 26, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add redirect support (limit: 6) dat-ecosystem-archive/dat-dns
3 participants
@staltz @RangerMauve @da2x