-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add redirect support (limit: 6) #27
base: master
Are you sure you want to change the base?
Conversation
Resolves issue dat-ecosystem-archive#25.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, I don't think I have publish rights though. 😀
@RangerMauve Why don't I add you to the npm package owners? |
@pfrazee That'd be swell. 💜 |
Could be useful to be added as a collaborator on the repo too. 😁 |
Sure thing! What's your npm username? |
Also rangermauve 😁 |
Done! |
The test relies on @staltz not changing his website. He hasn't done so in months even after the problem was identified in #25, so I hope it will work for some time. Ideally, all these tests should be hosted on a project controlled domain. Come to think of it, does any of you have access to set up a redirect from the old |
I've got access to our netlify and DNS stuff and could set that up. I think datproject.org and dat.foundation are both hosted from the same server so they'd have the same .well-known folder. I can set up another domain which does the redirect if you'd like. Same with DNS redirects. What should it contain? Something like |
@RangerMauve |
Interesting, a test case relying on my laziness to update my website! :) Granted, I think netlify (my host) will change how redirects work. See this email I got:
|
Match changes in dat-ecosystem-archive/dat-dns/pull/27.
Err, I don't think I'll have time for setting up the domains after all, but I can still merge this in if it's looking good to you @da2x. I've just got way too much on my plate right now. 😅 |
Match changes in dat-ecosystem-archive/dat-dns/pull/27.
Resolves issue #25.