-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add is_*_namespace
helper functions
#178
Conversation
fcf6b0a
to
67f3c9f
Compare
Let's make these not depend on the name array_api_compat. Vendoring supports renaming the module. We should be able to just compare against |
How should we do that? Create an array and pass it to Using just |
I mean the global variable |
sorry, I don't follow - what would one of the functions look like? |
Something like def _compat_module_name():
assert __name__.endswith('.common._helpers')
return __name__.removesuffix('.common._helpers') |
thanks, done |
Can we add some simple tests for this and also something in the vendoring test to make sure that works? |
Okay. Are there existing tests for the |
Yes, those are tested in test_common.py |
7a7f60d
to
bdcd14b
Compare
One more change and this can be merged: can you add these functions to the API docs? |
done (I think)! |
closes gh-156