Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: astype: add device kwarg #240

Merged
merged 2 commits into from
Jan 24, 2025
Merged

BUG: astype: add device kwarg #240

merged 2 commits into from
Jan 24, 2025

Conversation

crusaderky
Copy link
Contributor

Closes #226

@crusaderky
Copy link
Contributor Author

@ev-br @lucascolley ready for review

@crusaderky crusaderky mentioned this pull request Jan 23, 2025
Open
lucascolley
lucascolley approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @crusaderky !

@lucascolley lucascolley merged commit 73f6426 into data-apis:main Jan 24, 2025
42 checks passed
@lucascolley lucascolley changed the title ENH: astype: add device kwarg BUG: astype: add device kwarg Jan 24, 2025
@lucascolley lucascolley added the bug Something isn't working label Jan 24, 2025
@mdhaber mdhaber mentioned this pull request Jan 24, 2025
Open
@crusaderky crusaderky deleted the astype_device branch January 24, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucascolley lucascolley lucascolley approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2023.12 compat: astype has no device kwarg
2 participants
@crusaderky @lucascolley