Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dtype kwarg support to fftfreq and rfftfreq #885

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Jan 20, 2025

This PR

  • closes RFC: add support for a dtype kwarg to fftfreq and rfftfreq #717 by adding dtype kwarg support to fft.fftfreq and fft.rfftfreq.
  • aligns fftfreq and rfftfreq with other creation functions in allowing one to specify an output data type. Currently, these two FFT APIs have no means of inferring an output dtype precision, and thus default to the default real-valued floating-point data type.
  • limits what dtypes can be specified to real-valued floating-point data types.

@kgryte kgryte added the API change Changes to existing functions or objects in the API. label Jan 20, 2025
@kgryte kgryte added this to the v2024 milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API change Changes to existing functions or objects in the API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: add support for a dtype kwarg to fftfreq and rfftfreq
1 participant