Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Data from Python organizers into DU Format #3

Conversation

SangamSwadiK
Copy link
Contributor

@SangamSwadiK SangamSwadiK commented Jun 13, 2023

Issue: #2

What does this PR do?
Adds a notebook to clean data from Python organizers into DU format.
The notebook can be run once the data from Python organizers have been imported and the path is set.

@reshamas Please let me know in case of changes or suggestions.

Thanks.

Add README.md
Add Notebook to clean python organizers into DU format.
@SangamSwadiK SangamSwadiK requested a review from reshamas June 13, 2023 16:35
@reshamas
Copy link
Contributor

@SangamSwadiK Thanks for this!
I can't see the full notebook right now on GitHub.
Can you output the csv file and include it here in the PR?

@SangamSwadiK
Copy link
Contributor Author

@SangamSwadiK Thanks for this!
I can't see the full notebook right now on GitHub.
Can you output the csv file and include it here in the PR?

Hi, Sure. I'm sleeping right now. Will do it tomorrow morning.

Updated event data for 2023 and some in 2024, taken from python organizers.
@SangamSwadiK
Copy link
Contributor Author

@SangamSwadiK Thanks for this! I can't see the full notebook right now on GitHub. Can you output the csv file and include it here in the PR?

Hi, I've added the CSV file as well.
Thanks.

@reshamas
Copy link
Contributor

@SangamSwadiK
Best practices in coding is that folders do not have names with spaces in them "Notebooks to clean data in DU Format". Can you rename to: notebooks

Copy link
Contributor

@reshamas reshamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename folder following best practices for Unix and software engineering.

@reshamas reshamas merged commit e41e363 into data-umbrella:main Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants