Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for overriding list variable #2099

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Add test for overriding list variable #2099

merged 2 commits into from
Jan 9, 2025

Conversation

denik
Copy link
Contributor

@denik denik commented Jan 8, 2025 •
edited
Loading

  • Add override for "libraries".
  • Remove complexvar - it serves no purpose - we already have map variable ‘cluster’.

@denik denik temporarily deployed to test-trigger-is January 8, 2025 16:19 — with GitHub Actions Inactive
@denik denik enabled auto-merge January 8, 2025 16:26
pietern
pietern reviewed Jan 8, 2025
View reviewed changes
acceptance/bundle/variables/complex/databricks.yml Outdated
libraries:
- jar: "/newpath/to/jar"
- whl: "/newpath/to/whl"
- egg: "/newpath/to/egg"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nesting seems wrong. What are you defining here?

Copy link
Contributor Author

@denik denik Jan 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was it, after shifting it right it started to work. Thanks!

@denik denik temporarily deployed to test-trigger-is January 8, 2025 19:05 — with GitHub Actions Inactive
@denik denik force-pushed the denik/tests-complex-override-list branch from 9f04348 to 8a7f16a Compare January 8, 2025 19:12
@denik denik temporarily deployed to test-trigger-is January 8, 2025 19:12 — with GitHub Actions Inactive
@denik denik force-pushed the denik/tests-complex-override-list branch from 8a7f16a to acd35cc Compare January 8, 2025 19:13
@denik denik temporarily deployed to test-trigger-is January 8, 2025 19:13 — with GitHub Actions Inactive
@denik denik changed the title Add regression test for overriding list variable Add test for overriding list variable Jan 8, 2025
@denik denik requested a review from pietern January 8, 2025 19:39
@denik denik added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit b808d4d Jan 9, 2025
9 checks passed
@denik denik deleted the denik/tests-complex-override-list branch January 9, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietern pietern pietern approved these changes

@andrewnester andrewnester Awaiting requested review from andrewnester andrewnester is a code owner

@shreyas-goenka shreyas-goenka Awaiting requested review from shreyas-goenka shreyas-goenka is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denik @pietern