Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate path translation tests to acceptance tests #2122

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Migrate path translation tests to acceptance tests #2122

wants to merge 3 commits into from

Conversation

pietern
Copy link
Contributor

@pietern pietern commented Jan 10, 2025

Changes

The assertions on the output made in the original Go tests are now done with jq.

Tests

Tests pass.

@pietern pietern marked this pull request as ready for review January 10, 2025 17:57
@pietern pietern requested a review from andrewnester as a code owner January 10, 2025 17:57
@pietern pietern temporarily deployed to test-trigger-is January 10, 2025 17:57 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewnester andrewnester Awaiting requested review from andrewnester andrewnester is a code owner

@shreyas-goenka shreyas-goenka Awaiting requested review from shreyas-goenka shreyas-goenka is a code owner

@denik denik Awaiting requested review from denik denik is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pietern