Update impl.py to use POSIX standard on location #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsolasab
requested review from
andrefurlan-db,
benc-db and
rcypher-databricks
as code owners
|
Makes sense, just validating against the E2E tests. |
benc-db
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Executing dbt locally in a Windows machine is including front slash when using os.path.join function for separating different elements of the location and so generating issues when creating the tables.
Using posix join it will always use back slash to separate the elements of the location and so work in any operating system.
Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.