-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tables V2 #927
Open
benc-db
wants to merge
16
commits into
1.10.latest
Choose a base branch
from
tables_v2
base: 1.10.latest
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Tables V2 #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the next, and hopefully largest, chunk of migrating to Materializations V2: tackling table creation. As a reminder, the primary goal with Materializations V2 is to restructure materializations such that we first create the final destination, applying constraints, column comments, etc, then insert the required data. This allows us to a.) apply comments in bulk, b.) ensure that invalid data doesn't land in the final destination, and c.) allow for safe replacement strategies, where we first backup the existing table.
As with other large changes, this is gated behind a behavior flag so that it is initially opt-in; as such, there are large chunks of duplicated code so as not to disrupt the current behavior, but also prepare for eventually whole-sale deletion. Please start your review by looking at: https://github.com/databricks/dbt-databricks/blob/1ccc7d171dca4259807041505429e66bc59276e0/docs/table_flow.md, and dbt/include/databricks/macros/materializations/table.sql, where the structural changes are implemented.
The link to the markdown file should render as graphs showing the table materialization flow before and after changes.
This PR makes slight modifications to the new constraints logic, as I hit some bumps when adopting those changes.
Checklist
CHANGELOG.md
and added information about my change to the "dbt-databricks next" section.