Validate Privs for Create/Update

databricks · Feb 22, 2024 · 49e2d1e · 49e2d1e
1 parent 207dda6
commit 49e2d1e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/catalog/resource_grants.go b/catalog/resource_grants.go
@@ -330,6 +330,10 @@ func ResourceGrants() common.Resource {
 			var grants PermissionsList
 			common.DataToStructPointer(d, s, &grants)
 			securable, name := mapping.kv(d)
+			err = mapping.validate(d, grants)
+			if err != nil {
+				return err
+			}
 			unityCatalogPermissionsAPI := permissions.NewUnityCatalogPermissionsAPI(ctx, c)
 			err = replaceAllPermissions(unityCatalogPermissionsAPI, securable, name, grants.toSdkPermissionsList())
 			if err != nil {
@@ -373,6 +377,10 @@ func ResourceGrants() common.Resource {
 			}
 			var grants PermissionsList
 			common.DataToStructPointer(d, s, &grants)
+			err = mapping.validate(d, grants)
+			if err != nil {
+				return err
+			}
 			unityCatalogPermissionsAPI := permissions.NewUnityCatalogPermissionsAPI(ctx, c)
 			return replaceAllPermissions(unityCatalogPermissionsAPI, securable, name, grants.toSdkPermissionsList())
 		},

diff --git a/catalog/resource_grants_test.go b/catalog/resource_grants_test.go
@@ -9,7 +9,7 @@ import (
 )
 
 func TestPermissionsCornerCases(t *testing.T) {
-	qa.ResourceCornerCases(t, ResourceGrants(), qa.CornerCaseID("schema/sandbox"))
+	qa.ResourceCornerCases(t, ResourceGrants(), qa.CornerCaseSkipCRUD("Validation prevents CRUD"))
 }
 
 func TestGrantCreate(t *testing.T) {