Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate databricks_global_init_script to Go SDK #2036

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Conversation

nfx
Copy link
Contributor

@nfx nfx commented Feb 22, 2023

No description provided.

@alexott alexott marked this pull request as ready for review February 21, 2024 12:37
@alexott alexott requested review from a team as code owners February 21, 2024 12:37
@alexott alexott requested review from hectorcast-db and removed request for a team February 21, 2024 12:37
@codecov-commenter
Copy link

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (bb4acf7) 83.68% compared to head (aa67d62) 83.54%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2036      +/-   ##
==========================================
- Coverage   83.68%   83.54%   -0.15%     
==========================================
  Files         175      175              
  Lines       15873    15881       +8     
==========================================
- Hits        13284    13268      -16     
- Misses       1805     1823      +18     
- Partials      784      790       +6     
Files Coverage Δ
exporter/importables.go 79.47% <100.00%> (ø)
workspace/resource_global_init_script.go 80.55% <68.00%> (-10.07%) ⬇️

... and 3 files with indirect coverage changes

@hectorcast-db
Copy link
Contributor

hectorcast-db commented Feb 21, 2024

After this change, isn't the file workspace/global_init_scripts.go not needed anymore? (or most of it's contents) If so, can you remove it?

@alexott
Copy link
Contributor

alexott commented Feb 21, 2024

After this change, isn't the file workspace/global_init_scripts.go not needed anymore? (or most of it's contents) If so, can you remove it?

Good catch, forgot to remove it

@mgyucht mgyucht added this pull request to the merge queue Feb 22, 2024
Merged via the queue into main with commit b38e059 Feb 22, 2024
5 checks passed
@mgyucht mgyucht deleted the sdk/global-init-scripts branch February 22, 2024 13:50
@tanmay-db tanmay-db mentioned this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants