Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAT-101819] Improve documentation for INTERNAL and INTERNAL_AND_EXTERNAL delta sharing scope in terraform #3287

Merged
merged 3 commits into from
Feb 22, 2024
Merged

[PLAT-101819] Improve documentation for INTERNAL and INTERNAL_AND_EXTERNAL delta sharing scope in terraform #3287

merged 3 commits into from
Feb 22, 2024

Conversation

rongduan-zhu
Copy link
Contributor

Changes

Improve documentation for the INTERNAL and INTERNAL_AND_EXTERNAL values of delta_sharing_scope in terraform to clarify what they mean

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@rongduan-zhu rongduan-zhu requested review from a team as code owners February 21, 2024 21:33
@rongduan-zhu rongduan-zhu requested review from tanmay-db and linzhou-db and removed request for a team February 21, 2024 21:33
@alexott alexott added this pull request to the merge queue Feb 22, 2024
Merged via the queue into databricks:main with commit 2f75921 Feb 22, 2024
5 checks passed
@tanmay-db tanmay-db mentioned this pull request Mar 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linzhou-db linzhou-db linzhou-db approved these changes

@alexott alexott alexott approved these changes

@tanmay-db tanmay-db Awaiting requested review from tanmay-db tanmay-db is a code owner automatically assigned from databricks/eng-plat-auto-exp-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rongduan-zhu @alexott @linzhou-db