Removed CustomizeDiff and Client Side Validation for databricks_grants
#3290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanmay-db
requested review from
hectorcast-db
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3290 +/- ##
==========================================
- Coverage 83.63% 83.62% -0.02%
==========================================
Files 174 174
Lines 15866 15852 -14
==========================================
- Hits 13270 13256 -14
Misses 1807 1807
Partials 789 789
|
mgyucht
approved these changes
Feb 22, 2024
catalog/resource_grants.go
Outdated
| @@ -104,6 +104,7 @@ func (sm securableMapping) kv(d attributeGetter) (string, string) { | |||
| } | |||
| return field, v | |||
| } | |||
| fmt.Printf("[WARN] Unexpected resource or permissions. Please proceed at your own risk.") | |||
There was a problem hiding this comment.
We should use tflog.Warn here rather than printing out information: https://pkg.go.dev/github.com/hashicorp/terraform-plugin-log/tflog#Warn
There was a problem hiding this comment.
Yes, sorry about that, didn't push the latest commits. I have also removed the map because we can use the one in permissions.
tanmay-db
changed the title
CustomizeDiff and Client Side Validation for databricks_grants
tanmay-db
changed the title
CustomizeDiff and Client Side Validation for databricks_grantsCustomizeDiff and Client Side Validation for databricks_grants
5 tasks
mgyucht
approved these changes
Feb 22, 2024
nkvuong
approved these changes
Feb 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We remove client side validation for
databricks_grantsTests
Integration tests, updated unit tests, manually tested binary.
make testrun locallydocs/folderinternal/acceptance