Add customize diff for databricks_grant and databricks_grants for case insensitivity & spaces in grants
#3657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3657 +/- ##
==========================================
+ Coverage 81.59% 81.60% +0.01%
==========================================
Files 196 196
Lines 19719 19735 +16
==========================================
+ Hits 16089 16105 +16
Misses 2671 2671
Partials 959 959
|
nkvuong
changed the title
databricks_grant and databricks_grantsdatabricks_grant and databricks_grants to allow successful apply
nkvuong
changed the title
databricks_grant and databricks_grants to allow successful applydatabricks_grant and databricks_grants for case insensitivity & spaces in grants
edwardfeng-db
approved these changes
Jun 7, 2024
alexott
approved these changes
Jun 7, 2024
|
integration tests passed 🎉 |
hectorcast-db
added a commit
that referenced
this pull request
Jun 25, 2024
### New Features and Improvements * Add customize diff for `databricks_grant` and `databricks_grants` for case insensitivity & spaces in grants ([#3657](#3657)). * Fix detection of local file changes in `databricks_file` ([#3662](#3662)). * Apply all cluster validations to jobs cluster references ([#3651](#3651)). * Fixed: Issue with `databricks_cluster` resource using `exporter` does not include cluster libraries ([#3674](#3674)). * Relaxed cluster check for `databricks_sql_permissions` ([#3683](#3683)). * Update jobs library fields from set to list ([#3669](#3669)). * Added `CAN_MONITOR` permission to SQL warehouses in `databricks_permissions` ([#3681](#3681)). ### Documentation Changes * Fix errors in Unity Catalog data sources documentation ([#3656](#3656)). * Rename default_namespace_setting documentation to correct name ([#3682](#3682)). * Fix private DNS zone resource name in ADB PL Simplified guide ([#3664](#3664)). * Added links to Terraform modules and removed mention of E2 arch ([#3667](#3667)). ### Internal Changes * Update CodeQL actions to v3 ([#3648](#3648)). * Ensure jobs tests check for error ([#3666](#3666)). ### Dependency updates * Update to use Go 1.22 ([#3647](#3647)). * Bump github.com/databricks/databricks-sdk-go from 0.41.0 to 0.42.0 ([#3638](#3638)). * Bump github.com/databricks/databricks-sdk-go from 0.42.0 to 0.43.0 ([#3697](#3697)).
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 25, 2024
### New Features and Improvements * Add customize diff for `databricks_grant` and `databricks_grants` for case insensitivity & spaces in grants ([#3657](#3657)). * Fix detection of local file changes in `databricks_file` ([#3662](#3662)). * Apply all cluster validations to jobs cluster references ([#3651](#3651)). * Fixed: Issue with `databricks_cluster` resource using `exporter` does not include cluster libraries ([#3674](#3674)). * Relaxed cluster check for `databricks_sql_permissions` ([#3683](#3683)). * Update jobs library fields from set to list ([#3669](#3669)). * Added `CAN_MONITOR` permission to SQL warehouses in `databricks_permissions` ([#3681](#3681)). ### Documentation Changes * Fix errors in Unity Catalog data sources documentation ([#3656](#3656)). * Rename default_namespace_setting documentation to correct name ([#3682](#3682)). * Fix private DNS zone resource name in ADB PL Simplified guide ([#3664](#3664)). * Added links to Terraform modules and removed mention of E2 arch ([#3667](#3667)). ### Internal Changes * Update CodeQL actions to v3 ([#3648](#3648)). * Ensure jobs tests check for error ([#3666](#3666)). ### Dependency updates * Update to use Go 1.22 ([#3647](#3647)). * Bump github.com/databricks/databricks-sdk-go from 0.41.0 to 0.42.0 ([#3638](#3638)). * Bump github.com/databricks/databricks-sdk-go from 0.42.0 to 0.43.0 ([#3697](#3697)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
EqualFoldto allow validation to complete.DiffSuppressFuncforprincipalattribute indatabricks_grantdatabricks_grantsresource and "MANAGE ALLOWLIST" #3566, [ISSUE] Issue withdatabricks_grantsresource #3261, [ISSUE] Issue withdatabricks_grantresource. Resources get created correctly but terraform errors. #3313Tests
make testrun locallyinternal/acceptance