Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: [Feature] Add databricks_git_folder resource to replace databricks_repo #4133

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

840
Copy link
Contributor

@840 840 commented Oct 21, 2024

Changes

According to Databricks - What happened to Databricks Repos?, Databricks Repos is being deprecated in favour of Git Folders. This PR aims to add databricks_git_folder resource and deprecate databricks_repo resource.

Resolves #3877

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@840 840 requested review from a team as code owners October 21, 2024 12:56
@840 840 requested review from renaudhartert-db and removed request for a team October 21, 2024 12:56
@840 840 marked this pull request as draft October 21, 2024 12:56
@renaudhartert-db renaudhartert-db requested review from alexott and tanmay-db and removed request for alexott and renaudhartert-db October 24, 2024 09:02
@tanmay-db
Copy link
Contributor

Hi @840, just wanted to confirm before review -- is the PR ready for review? asking because some tests are failing.

@840
Copy link
Contributor Author

840 commented Oct 24, 2024

Hey @tanmay-db, I'm still working on it. I'll add WIP in the title.

@840 840 changed the title [Feature] Add databricks_git_folder resource to replace databricks_repo WIP: [Feature] Add databricks_git_folder resource to replace databricks_repo Oct 24, 2024
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4133
  • Commit SHA: 2a673e5fc683e84131d48c0202bb9645bce2b3e1

Checks will be approved automatically on success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add dedicated databricks_git_folder resource and deprecate databricks_repo
2 participants