[Fix] Fix deletion of dashboard if it was trashed out of band #4235
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
If a dashboard created by TF was trashed out of band, it could no longer be deleted by TF.
Example TF configuration:
If you apply this, and then run:
The subsequent apply would error out with:
It turns out trashing an already trashed dashboard returns an error.
This change guards against this condition returns success if the underlying dashboard has already been trashed.
Tests
make test
run locallydocs/
folderinternal/acceptance