Quorum-based Series() query short circuit #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hczhu-db
reviewed
Mar 7, 2025
| @@ -655,6 +665,9 @@ func newEagerRespSet( | |||
| resp, err := cl.Recv() | |||
| if err != nil { | |||
| if err == io.EOF { | |||
There was a problem hiding this comment.
Also check if this is response stream is canceled by another stream because the quorum is reached.
if err == context.Canceled {
log something
pkg/store/proxy_merge.go
Outdated
| @@ -665,6 +678,8 @@ func newEagerRespSet( | |||
| <-t.C // Drain the channel if it was already stopped. | |||
| } | |||
| rerr = errors.Wrapf(err, "failed to receive any data in %s from %s", l.frameTimeout, storeName) | |||
| } else if qg != nil && qg.counter.Load() >= qg.quorum { | |||
| rerr = errors.Wrapf(err, "quorum reached and canceled %s", storeName) | |||
There was a problem hiding this comment.
Better error message .. cancelled all other pending response streams.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cancel the last store if all other stores returns no error