Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add filter to rule #141

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: add filter to rule #141

wants to merge 3 commits into from

Conversation

pierre-monnet
Copy link

@pierre-monnet pierre-monnet commented Jan 28, 2025 •
edited
Loading

Changes

Add filter to Rule

Linked issues

Resolves #140

Tests

  • manually tested
  • added unit tests
  • added integration tests

@pierre-monnet pierre-monnet requested a review from a team as a code owner January 28, 2025 15:05
@pierre-monnet pierre-monnet requested review from gergo-databricks and removed request for a team January 28, 2025 15:05
@pierre-monnet pierre-monnet mentioned this pull request Jan 28, 2025
Open
1 task
@mwojtyczka
Copy link
Contributor

mwojtyczka commented Jan 29, 2025 •
edited
Loading

Thank you for your PR. Added a few comments.
We currently have issue in our CI that they don't run on forks. Once this is solved, we should be able to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gergo-databricks gergo-databricks Awaiting requested review from gergo-databricks gergo-databricks is a code owner automatically assigned from databrickslabs/dqx-write

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Add filter to rule
2 participants
@pierre-monnet @mwojtyczka