Initial Spec For Credential Management and SQLAlchemy Database Connectors #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericvergnaud
requested changes
Jan 21, 2025
| with open(file_path, encoding="utf-8") as f: | ||
| return yaml.safe_load(f) | ||
|
|
||
| def get(self, source: str) -> dict[str, str]: |
| raise KeyError(error_msg) | ||
| raise KeyError(error_msg) | ||
|
|
||
| def get_secret_value(self, key: str) -> str: |
There was a problem hiding this comment.
Wouldn't get_secret suffice ?
There is infra to test it I will add an integration test using envgetter. |
ericvergnaud
requested changes
Jan 24, 2025
|
|
||
|
|
||
| class EnvGetter: | ||
| def __init__(self, is_debug: bool = False): |
There was a problem hiding this comment.
Why not read debug-env.json when the app starts and set env variables accordingly (using os.environ['my_name'] = 'my_value') ?
Add Integration Test
|
✅ 2/2 passed, 2s total Running from acceptance #64 |
sundarshankar89
changed the base branch from
main
to
feature/simplified_installation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial Spec For Credential Management and SQLAlchemy Database Connectors