Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blurring correction #313

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

JeremyPike
Copy link
Contributor

@JeremyPike JeremyPike commented Dec 8, 2023

Corrects use of img_as_ubyte which should be called as ski.img_as_ubyte. Also cleans things up and removes some imports which were already performed at the beginning of the episode.

Copy link

github-actions bot commented Dec 8, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/image-processing/compare/md-outputs..md-outputs-PR-313

The following changes were observed in the rendered markdown documents:

 06-blurring.md | 23 +++--------------------
 md5sum.txt     |  2 +-
 2 files changed, 4 insertions(+), 21 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-12-08 14:26:30 +0000

@JeremyPike JeremyPike marked this pull request as ready for review December 8, 2023 14:26
github-actions bot pushed a commit that referenced this pull request Dec 8, 2023
Copy link
Member

@tobyhodges tobyhodges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JeremyPike 🙌

@tobyhodges tobyhodges merged commit 333009e into datacarpentry:main Dec 8, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 8, 2023
Auto-generated via {sandpaper}
Source  : 333009e
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2023-12-08 15:08:20 +0000
Message : Merge pull request #313 from bear-rsg/blurring-suggestions

Blurring correction
github-actions bot pushed a commit that referenced this pull request Dec 8, 2023
Auto-generated via {sandpaper}
Source  : e7830c2
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-12-08 15:09:38 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 333009e
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2023-12-08 15:08:20 +0000
Message : Merge pull request #313 from bear-rsg/blurring-suggestions

Blurring correction
@mkcor
Copy link
Contributor

mkcor commented Dec 9, 2023

Corrects use of img_as_ubyte which should be called as ski.img_as_ubyte.

Correct, but I would rather use ski.util.img_as_ubyte, so it's consistent with episode 03.

@JeremyPike JeremyPike deleted the blurring-suggestions branch February 2, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants