Add bare bone APIs for observation and event #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradh
reviewed
Nov 7, 2022
|
|
||
|
|
||
| def event_series_within_place(event_type: str, containing_place: str, | ||
| date: str): |
There was a problem hiding this comment.
We probably want to use variable here too? Couple of options:
-
Use the same API as observation_series() and friends, except, depending on the variable (Count_EarthquakeEvent vs. List_EarthquakeEvent), the returned value will have entities per date, rather than a value per date.
-
Use very similar API structure as observation_series(), but these are "event" versions. We use the existing variables (e.g.,
Count_EarthquakeEvent), and this new API returns entities per data point.
There was a problem hiding this comment.
my preference would be for (2)
rather than event, should we use entity to be more extensible?
|
|
||
| from typing import List | ||
|
|
||
|
|
|
Do we want this as py-only API or REST API first? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to finalize the naming of Python API for observation and event.