NCBI Summary Report PR #1020
Merged
NCBI Summary Report PR #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
fill in missing sections in README.md
update Quantity dcid generation description
spiekos
reviewed
Jun 25, 2024
There was a problem hiding this comment.
There are critical errors in the data processing of this file. This is not ready for import as is. Please resolve critical errors being generated by the data commons json report tool. As part of resolving these errors the updated mcf files are uploaded to the shared drive. In addition, I noted where several the errors are being generated from - in detail - as comments on the test.sh and process.py files in this PR.
scripts/biomedical/NCBI_Assembly/Summary_Report/scripts/download.sh
Outdated
Show resolved
Hide resolved
scripts/biomedical/NCBI_Assembly/Summary_Report/scripts/process_test.py
Outdated
Show resolved
Hide resolved
scripts/biomedical/NCBI_Assembly/Summary_Report/scripts/process.py
Outdated
Show resolved
Hide resolved
scripts/biomedical/NCBI_Assembly/Summary_Report/scripts/test.sh
Outdated
Show resolved
Hide resolved
fix bugs in processing links to Taxon nodes
Add initiation of referenced Taxon nodes
spiekos
reviewed
Jul 9, 2024
update subsections on new schema and caveats
update new schema subsection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.