Skip to content

Commit

Permalink
Stanford Staging: Do not inherit Stanford prod config (#1898)
Browse files Browse the repository at this point in the history
It is easy to make mistakes if the staging config is inherited from prod
config. For example, the staging instance is currently trying to read
the prod GCS bucket because the GCS bucket is not set explicitly in
config.


![image](https://user-images.githubusercontent.com/8507196/208184003-d817889a-f604-4b58-a009-812d3c63a2ff.png)

Co-authored-by: Alex Chen <[email protected]>
  • Loading branch information
Fructokinase and Alex Chen authored Dec 16, 2022
1 parent 0430340 commit 085aa73
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion server/configmodule.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,12 @@ class StanfordConfig(CustomConfig):
GCS_BUCKET = 'datcom-stanford-resources'


class StanfordStagingConfig(StanfordConfig):
class StanfordStagingConfig(CustomConfig):
NAME = "Google Stanford Data Commons (Staging)"
ENV_NAME = 'STANFORD'
ENABLE_BLOCKLIST = True
BASE_HTML_PATH = 'custom_dc/stanford/base.html'
GCS_BUCKET = 'datcom-stanford-staging-resources'
API_PROJECT = 'datcom-mixer-statvar'
SECRET_PROJECT = 'datcom-stanford-staging'

Expand Down

0 comments on commit 085aa73

Please sign in to comment.