place page: fix whitespace and scroll (#4613)

removes pinned-scroll behavior on wider screens
datacommonsorg · Sep 11, 2024 · 7adc768 · 7adc768
1 parent bf53d40
commit 7adc768
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/server/templates/place.html b/server/templates/place.html
@@ -44,14 +44,14 @@
 <div id="body" class="container-fluid">
   <div id="nl-search-bar"></div>
   <div id="body-row" class="row">
-    <div id="sidebar-outer" class="col-md-3x col-lg-2 order-last order-lg-0">
-      <div id="sidebar-top-spacer" class="d-none d-lg-block"></div>
+    <div id="sidebar-outer" class="col-md-3x col-xl-2 order-last order-xl-0">
+      <div id="sidebar-top-spacer" class="d-none d-xl-block"></div>
       <div id="sidebar-region">
         <div id="menu"></div>
         <div id="child-place"></div>
       </div>
     </div>
-    <div id="main" class="col-md-9x col-lg-10">
+    <div id="main-place" class="col-md-9x col-xl-10">
       <div id="title" data-dcid="{{ place_dcid }}">
         <div id="place-heading-container">
           <div id="place-heading">

diff --git a/static/js/place/chart.tsx b/static/js/place/chart.tsx
@@ -380,7 +380,7 @@ class Chart extends React.Component<ChartPropType, ChartStateType> {
     } catch (e) {
       return;
     }
-    updatePageLayoutState();
+    // updatePageLayoutState();
   }
 
   componentWillUnmount(): void {

diff --git a/static/js/place/place.ts b/static/js/place/place.ts
@@ -53,9 +53,11 @@ const Y_SCROLL_MARGIN = 100;
 window.addEventListener("load", (): void => {
   try {
     renderPage();
-    updatePageLayoutState();
-    maybeToggleFixedSidebar();
-    window.onresize = maybeToggleFixedSidebar;
+    // Disable sidebar pinning.
+    // TODO(beets): Delete this code.
+    // updatePageLayoutState();
+    // maybeToggleFixedSidebar();
+    // window.onresize = maybeToggleFixedSidebar;
   } catch (e) {
     return;
   }
@@ -234,7 +236,7 @@ function renderPage(): void {
       }
 
       // Readjust sidebar based on parent places.
-      updatePageLayoutState();
+      // updatePageLayoutState();
 
       // Display child places alphabetically
       for (const placeType in data.allChildPlaces) {