~80 additional lint fixes #4835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chejennifer
approved these changes
Jan 10, 2025
| const fetchData = async (props: GaugeTilePropType) => { | ||
| const fetchData = async ( | ||
| props: GaugeTilePropType | ||
| ): Promise<{ |
There was a problem hiding this comment.
nit: for these large objects as return types, maybe should define a type for them & in fact, for this one, can just use GaugeChartData
There was a problem hiding this comment.
So I used GaugeChartData here.
Right now most of these large objects that we should name I think I skipped them (they're in the remaining 99 lints).
Some of the ones in this PR are a bit large but I think they're always only ever used once / twice and are very custom so I didnt think these deserved to be typed properly. Lmk if you think there are some in this PR that should be!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some react hook dependency arrays, some lint errors to skip and some return types to add.
Down to 99 lint warnings.