[Place Page Revamp] Filters out charts that have no data #4842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype selection imrpoved.
…lace page for california. More testing to come.
…still need to fix for Peers within parent.
…atedplaces response to pass it into place charts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the fix for removing charts that have no data on either of the cases according to their block scope.
So either for the current place, the child places, or the peer places within the parent.
Modifies the call to relatedPlaces such that it comes BEFORE placeCharts (as opposed to in parallel). We have to do this in order to pass in the parent place dcid to the placeCharts method so that we can verify we have data for peer places within parent.
With this change, all charts that have NO data are removed.