Updated terraform configuration to initialize empty input and ouput directories #4843
Conversation
| @@ -73,6 +73,18 @@ variable "dc_gcs_data_bucket_path_override" { | |||
| default = "" | |||
| } | |||
|
|
|||
| variable "dc_gcs_data_bucket_input_folder" { | |||
There was a problem hiding this comment.
This is great! I wonder if we need the "dc" prefix, since we don't use it for other services. Also, is it possible to remove "path" from the previous option? It's kind of misleading since it's only the bucket name. Can we also remove the "override"? We don't name any other optional variables that way, so it seems weird here. I would just call it "gcs_data_bucket_name".
There was a problem hiding this comment.
Good call. Removed dc_ prefix to all of the bucket variables, and renamed the bucket name to gcs_data_bucket_name
| @@ -360,7 +374,7 @@ resource "google_cloud_run_v2_job" "dc_data_job" { | |||
|
|
|||
| env { | |||
| name = "INPUT_DIR" | |||
| value = "gs://${local.dc_gcs_data_bucket_path}/input" | |||
| value = "gs://${local.dc_gcs_data_bucket_path}/${var.dc_gcs_data_bucket_input_folder}" | |||
There was a problem hiding this comment.
Do we also need one for OUTPUT_DIR, since we're giving them that variable too?
There was a problem hiding this comment.
Already added that! dc_gcs_data_bucket_output_folder
…_override to gcs_data_bucket_name
…ub.com/dwnoble/website into tf-initialize-input-output-directories
New variables:
Renamed
dc_gcs_data_bucket_path_overridetogcs_data_bucket_nameRenamed
dc_gcs_data_bucket_locationtogcs_data_bucket_location