Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added geo existence check to place page chart filtering logic #4894

Merged
merged 7 commits into from
Jan 27, 2025

Conversation

dwnoble
Copy link
Contributor

@dwnoble dwnoble commented Jan 26, 2025

  • Adds geo data existence check for child places & peer places map
  • Sequentially checks geoJsonCoordinatesDP3 (lowest-resolution) and falls back to geoJsonCoordinatesDP2 if no geoJsonCoordinatesDP3 is available.
  • This check adds a good amount of latency to the chart filtering process (the response time is around ~4s total for California)

Before
before-ggy

After
after-ggy

@dwnoble dwnoble requested a review from gmechali January 27, 2025 07:21
@dwnoble dwnoble marked this pull request as ready for review January 27, 2025 07:21
@gmechali
Copy link
Contributor

LGTM - but do you think it's worth the additional latency that you call out?
Perhaps something we could try is to hide the geo existence check behind a feature flag so that if we start seeing some other metrics drop (and we fear it could be latency related), we can turn it off easily?

@dwnoble
Copy link
Contributor Author

dwnoble commented Jan 27, 2025

LGTM - but do you think it's worth the additional latency that you call out? Perhaps something we could try is to hide the geo existence check behind a feature flag so that if we start seeing some other metrics drop (and we fear it could be latency related), we can turn it off easily?

The latency should be OK in prod due to the caching & cache warming. Agreed it would be good to have a feature flag for this. I'll leave this for a follow-up, but maybe the feature flag behavior can be:

  • Enabled: Perform geo existence check from this PR
  • Disabled: Only show maps for a limited subset of places that we know we have geos for (Earth + US Places?)

@dwnoble dwnoble merged commit 0424d9a into datacommonsorg:master Jan 27, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants