-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor dim_orgs and incorporate changes into sales_sync #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Base branch | Pull Request branch |
master-bigquery (417ccea) | update-dim_orgs (724e639) |
- Different: 2
- Identical: 1
datafold-demo-429713.prod.dim__orgs | ||||||||||||||||
Primary keys org_id |
||||||||||||||||
DIFFERENCES | ||||||||||||||||
3 column(s) with differing values
|
||||||||||||||||
View details → | ||||||||||||||||
Unchanged Attributes
|
datafold-demo-429713.prod.sales__sync | ||||||||||||||
Primary keys org_id |
||||||||||||||
master-bigquery | update-dim_orgs | |||||||||||||
DIFFERENCES | ||||||||||||||
Total rows | 29 | ↑ 60 +106.9% | ||||||||||||
Exclusive PKs | 0 | 31 | ||||||||||||
View details → | ||||||||||||||
Unchanged Attributes
|
datafold-demo-429713.prod.dim__users | ||||||||||||||||||
Primary keys user_id |
||||||||||||||||||
View details → | ||||||||||||||||||
Unchanged Attributes
|
Skipped Data Diffs of downstream tables: 2
Add "datafold:diff-all-downstream" label to this pull request to diff all affected tablesdatafold-demo-429713.prod.fct__yearly__financials (table) | Run Data Diff → |
datafold-demo-429713.prod.fct__monthly__financials (table) | Run Data Diff → |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Base branch | Pull Request branch |
master-bigquery (417ccea) | update-dim_orgs (724e639) |
- Different: 2
- Identical: 1
datafold-demo-429713.prod.sales__sync | ||||||||||||||
Primary keys org_id |
||||||||||||||
master-bigquery | update-dim_orgs | |||||||||||||
DIFFERENCES | ||||||||||||||
Total rows | 29 | ↑ 60 +106.9% | ||||||||||||
Exclusive PKs | 0 | 31 | ||||||||||||
View details → | ||||||||||||||
Unchanged Attributes
|
datafold-demo-429713.prod.dim__orgs | ||||||||||||||||
Primary keys org_id |
||||||||||||||||
DIFFERENCES | ||||||||||||||||
3 column(s) with differing values
|
||||||||||||||||
View details → | ||||||||||||||||
Unchanged Attributes
|
datafold-demo-429713.prod.dim__users | ||||||||||||||||||
Primary keys user_id |
||||||||||||||||||
View details → | ||||||||||||||||||
Unchanged Attributes
|
- Different: 2
datafold-demo-429713.prod.fct__monthly__financials | ||||||||||||||||
Primary keys date_month |
||||||||||||||||
DIFFERENCES | ||||||||||||||||
1 column(s) with differing values
|
||||||||||||||||
View details → | ||||||||||||||||
Unchanged Attributes
|
||||||||||||||||
Modified upstream modelsmodel.demo.dim__orgs |
datafold-demo-429713.prod.fct__yearly__financials | ||||||||||||||||
Primary keys date_year |
||||||||||||||||
DIFFERENCES | ||||||||||||||||
1 column(s) with differing values
|
||||||||||||||||
View details → | ||||||||||||||||
Unchanged Attributes
|
||||||||||||||||
Modified upstream modelsmodel.demo.dim__orgs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dim_orgs.created_at
dim_orgs
model is built around the first usersign_up
event, but I noticed we have anorg_created
event that might make more sense to use.sign_up
events fororg_created
events in modeldim_orgs
dim_orgs.sub_price
to0
when the value would benull
.dim_orgs.sub_plan
toIndividual
whennum_users
is1
Individual
opportunities in the Sales Sync.num_users
.