Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "test changes" #6

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Revert "test changes" #6

merged 1 commit into from
Feb 7, 2024

Conversation

sungchun12
Copy link
Contributor

Reverts #5

This reverts commit c2c29ce.
Copy link

@datafold datafold bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base branch Pull Request branch
main (c2c29ce) revert-5-brand-new-branch (e00f454)
 Data Diffs of tables modified in this pull request: 2
DEMO.CORE.DIM_ORGS
Primary keys ORG_ID
main revert-5-brand-new-b...
DIFFERENCES
  Total rows 146 157 +7.5%
  Exclusive PKs 0 11
 2 column(s) with differing values
column number of rows
CREATED_AT 112  76.7%
SUB_PLAN 94  64.4%
 
NO DIFFERENCES
Total columns 6
Schema changes 0
Common unique PKs 146
Rows with NULL PKs 0
Rows with duplicate PKs 0
 
Data app dependencies
 Mode — 1
 Looker — 4
 Tableau — 11
 Hightouch — 1
View details →

DEMO.CORE.SALES_SYNC
Primary keys ORG_ID
main revert-5-brand-new-b...
DIFFERENCES
  Total rows 3 4 +33.3%
  Exclusive PKs 1 2
 
NO DIFFERENCES
Total columns 2
Schema changes 0
Common unique PKs 2
Rows with NULL PKs 0
Rows with duplicate PKs 0
Columns with different values 0
 
Data app dependencies
 Hightouch — 1
View details →

Skipped Data Diffs of downstream tables: 2 Add "datafold:diff-all-downstream" label to this pull request to diff all affected tables
DEMO.CORE.fct_yearly_financials (view) Run Data Diff →
DEMO.CORE.fct_monthly_financials (view) Run Data Diff →

@sungchun12 sungchun12 merged commit 9caf5cd into main Feb 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant