Merge pull request #434 from datafruits/fix-voting-completion-percentage

fix shrimpo voting completion bug
datafruits · Oct 12, 2024 · 2f6800e · 2f6800e
2 parents 463fed6 + 19c81e3
commit 2f6800e
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/app/models/shrimpo.rb b/app/models/shrimpo.rb
@@ -206,9 +206,9 @@ def create_entries_zip
   end
 
   def voting_completion user
-    voted_count = ShrimpoVote.where(user: user).where("shrimpo_entry_id in (?)", self.shrimpo_entries.pluck(:id)).count
+    voted_count = ShrimpoVote.where(user: user).where("shrimpo_entry_id in (?)", self.shrimpo_entries.pluck(:id)).select(:shrimpo_entry_id).distinct.count
     total_count = self.shrimpo_entries.count
-    (voted_count.to_f / total_count.to_f) * 100
+    ((voted_count.to_f / total_count.to_f) * 100).round(2)
   end
 
   private