Feat/use harvest metadata #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
external_source is still used here, in both the condition and href, as a variable instead of a function : https://github.com/etalab/udata-front/pull/168/files#diff-d5e0edc6387330398745e23afaaa276b2986de431e4589cc4db452a45903f541R223
I can't make the suggestion with GH interface because this part didn't change.
nicolaskempf57
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows opendatateam/udata#2762.
Display harvest metadata in an html toggle next to extras toggle.
Show dates on top of dataset page and dataset card even for harvested datasets.
Use
last_update, now based on more recent date for resources (modified, published and harvest modified date): opendatateam/udata#2762 (comment).This is a minimal step to mitigate the impact of separating the harvest dates, before dealing with datagouv/data.gouv.fr#856