Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update repo architecture and README #32

Merged
merged 72 commits into from
Sep 18, 2023
Merged

Update repo architecture and README #32

merged 72 commits into from
Sep 18, 2023

Conversation

MilagrosMarin
Copy link
Collaborator

@MilagrosMarin MilagrosMarin commented Jul 25, 2023 •
edited
Loading

The following tasks have been completed by merging this Pull Request:

  • Update repository architecture
    • Rename directory notebooks to tutorials
    • Rename directory completed exercises to completed tutorials
    • Delete 00-Getting Started as these instructions are not applicable with Dev Container
    • Merge tutorial_pipeline files into the notebooks
  • Update Dockerfile to include gcc library
  • Update README
    • Add Table of contents section
    • Add Key learnings from the tutorials section

@MilagrosMarin
Extended introduction, explanations and definitions added. Restructur…
1ffb456 
…e. Miniscope tutorial added.
@MilagrosMarin
Update README: Installation extended, Miniscope tutorial reference de…
6c96c3b 
…leted.
@MilagrosMarin
Updated README to add Table of contents
5c55ac1
@MilagrosMarin
Added gcc install to Dockerfile
1223ebf
@MilagrosMarin
Added configuration DJ instructions to tutorial 01
1147024
@MilagrosMarin
Tutorials organized in two folders and renamed
30f4b61
@MilagrosMarin
Deleted Tutorial 00-Getting Started.ipynb
9860c63
@MilagrosMarin
Tutorial 01 Deleted Configuration and Pipeline def update
5ff0746
@MilagrosMarin
Updated Table of Contents in README
d1d368c
@MilagrosMarin
Update bullet points in Installation
73fee2e
@MilagrosMarin
Minor typos in README.md
f742227
@MilagrosMarin
Update Data pipelines Concept in tutorial 01.
f4cbd5d
@MilagrosMarin
Update Data pipelines-Practical Example-Tutorial01
b05310e
@MilagrosMarin
Update Practical example-Data pipelines-Tutorial01
1d57fa2
@MilagrosMarin
Update of Practical Example -final part-Tutorial01
0be639c
@MilagrosMarin
Major changes in text and organization-Tutorial01
6f34d64
@MilagrosMarin
Minor: Summary added in the index
feb0845
@MilagrosMarin
Update Tutorial01 to add minor typos
2e03eda
kabilar
kabilar reviewed Jul 25, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
kabilar
kabilar reviewed Jul 25, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
kabilar
kabilar reviewed Jul 25, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
kabilar
kabilar reviewed Jul 25, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
kabilar
kabilar reviewed Jul 25, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
kabilar
kabilar reviewed Jul 25, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@kabilar kabilar marked this pull request as draft July 25, 2023 21:53
@kabilar
Copy link
Collaborator

kabilar commented Jul 25, 2023

Based on our discussion, drafted this pull request so that you can continue to make updates before we merge.

MilagrosMarin and others added 2 commits July 25, 2023 17:18
@MilagrosMarin @kabilar
Update README.md
8ebe8bf 
Co-authored-by: Kabilar Gunalan <[email protected]>
@MilagrosMarin @kabilar
Update README.md
f3ec2d2 
Co-authored-by: Kabilar Gunalan <[email protected]>
kabilar
kabilar reviewed Sep 17, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@kabilar kabilar marked this pull request as ready for review September 17, 2023 20:51
kabilar
kabilar requested changes Sep 17, 2023
View reviewed changes
Copy link
Collaborator

@kabilar kabilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @MilagrosMarin. Please see my suggestions above.

MilagrosMarin and others added 14 commits September 18, 2023 12:53
@MilagrosMarin @kabilar
Update README.md
159706d 
Co-authored-by: Kabilar Gunalan <[email protected]>
@MilagrosMarin @kabilar
Update README.md
20331ec 
Co-authored-by: Kabilar Gunalan <[email protected]>
@MilagrosMarin @kabilar
Update README.md
805d7da 
Co-authored-by: Kabilar Gunalan <[email protected]>
@MilagrosMarin @kabilar
Update README.md
218856c 
Co-authored-by: Kabilar Gunalan <[email protected]>
@MilagrosMarin @kabilar
Update README.md
7a84d49 
Co-authored-by: Kabilar Gunalan <[email protected]>
@MilagrosMarin @kabilar
Update README.md
0960b1b 
Co-authored-by: Kabilar Gunalan <[email protected]>
@MilagrosMarin @kabilar
Update README.md
97c102a 
Co-authored-by: Kabilar Gunalan <[email protected]>
@MilagrosMarin @kabilar
Update README.md
21b231d 
Co-authored-by: Kabilar Gunalan <[email protected]>
@MilagrosMarin @kabilar
Update README.md
1417540 
Co-authored-by: Kabilar Gunalan <[email protected]>
@MilagrosMarin @kabilar
Update README.md
d29fc85 
Co-authored-by: Kabilar Gunalan <[email protected]>
@MilagrosMarin @kabilar
Update README.md
e8e2113 
Co-authored-by: Kabilar Gunalan <[email protected]>
@MilagrosMarin @kabilar
Update README.md
8d3ecb2 
Co-authored-by: Kabilar Gunalan <[email protected]>
@MilagrosMarin @kabilar
Update README.md
5f1e9a7 
Co-authored-by: Kabilar Gunalan <[email protected]>
@MilagrosMarin
Move Developer Instructions to the end of README
cc529a7
@MilagrosMarin
Copy link
Collaborator Author

Thank you, @MilagrosMarin. Please see my suggestions above.

Thank you, @kabilar!

kabilar
kabilar reviewed Sep 18, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
kabilar
kabilar reviewed Sep 18, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
kabilar
kabilar approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@kabilar kabilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @MilagrosMarin!

@kabilar kabilar merged commit 4e5835d into datajoint:main Sep 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kabilar kabilar kabilar approved these changes

Assignees

@MilagrosMarin MilagrosMarin

Labels
None yet
Projects
DataJoint Open-Source Software
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MilagrosMarin @kabilar