Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let reviews have multiple owners #90

Merged
merged 35 commits into from
Dec 10, 2023
Merged

Let reviews have multiple owners #90

merged 35 commits into from
Dec 10, 2023

Conversation

bdewilde
Copy link
Member

@bdewilde bdewilde commented Dec 8, 2023 •
edited
Loading

changes

  • adds proper association object / database table to manage a many-to-many relationship between reviews and users where user role is now a proper attribute
  • adds "set_role" action to existing PUT reviews/{id}/team api endpoint as a more flexible replacement for deprecated "make_owner" action
  • adds some unit tests for review team api endpoints
  • adds better logging to auth api endpoints
  • drops black+isort in favor of ruff for linting and formatting, w/ corresponding tool configuration
  • bumps a couple github action versions in checks workflow

@bdewilde
feat: Add better logging for auth api
48d03a0
@bdewilde
feat: Add better user api resource logging
3b24f6e
@bdewilde
[build] Tweak ruff config
32da273
@bdewilde
refactor: Reorder data source model
696b330 
this just makes things easier to read top-down
@bdewilde
feat: Update db models for new user/review assoc
2bf769f
@bdewilde
wip hacks
d846d7e
@bdewilde
feat: Add db migration for new review/user assoc
e7fdd74
@bdewilde
fix: Rename+configure user/review relationships
1045357
@bdewilde
feat: Populate review-user-assoc via cli+seed
4bfd71b
@bdewilde
fix: Return owner/owned user/review props working
9c7ef6c
@bdewilde
fix: Allow multi owners in review api
40de3a9
@bdewilde
fix: Use new review-user assoc in fulltext api
19bfab7
@bdewilde
fix: Make user/review assoc rel dynamic lazy
f20a6db 
no idea why this works, but apparently it does
@bdewilde
feat: Remove owner_user_id from review
9783944 
for both db model and api schema
@bdewilde
feat: Remove owner user id from review
63c241a 
in post api endpoint and test fixture data
@bdewilde
fix: Update review owner calls in api endpoints
1d820ca
@bdewilde
feat: Init rev-usr-assoc w/ optional role
bcd1e1e
@bdewilde
fix: Fix review team change logic for assoc obj
ea86332
@bdewilde
feat: Remove old server name api arg
5331901
@bdewilde
lint: Auto-format random code
f10f799
@bdewilde
feat: Add api args to set user role in team
7efc166
@bdewilde
feat: Update review user filtering
00be3f8
@bdewilde
feat: Update user review filtering
04225fd
@bdewilde
lint: Auto-format some code
496406e
@bdewilde
feat: Fix one last review user assoc filter stmt
d104028 
not sure how this got missed
@bdewilde
build: Bump versions on gh actions
d5fe401
@bdewilde
build: Switch to ruff-only lint+fmt in pyproject
af1f6f4
@bdewilde
build: Only use ruff for format+lint
e9ab000
@bdewilde
lint: Fix some linting errors
0f53e5d
@bdewilde
build: Tweak ruff configuration
59af7ba
@bdewilde bdewilde marked this pull request as ready for review December 10, 2023 02:01
@bdewilde bdewilde merged commit 5075b5e into develop Dec 10, 2023
3 checks passed
@bdewilde bdewilde deleted the burton-resolve-dangling-todos branch December 10, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bdewilde