Add getEntriesData endpoint #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepanenkoxx
commented
Dec 28, 2024
| import {ACCESS_DENIED_ERROR_CODE, NOT_FOUND_ERROR_CODE} from './constants'; | ||
|
|
||
| export type GetEntriesDataResponseItemResult = { | ||
| scope: Nullable<EntryScope>; |
There was a problem hiding this comment.
We have nullable type in our Entry model
Can it really be null?
There was a problem hiding this comment.
it can be null in db schema.
stepanenkoxx
commented
Dec 28, 2024
| @@ -11,10 +11,10 @@ export interface DLSConstructor { | |||
| checkPermissionsArgs: MT.CheckPermissionDlsConfig, | |||
| ) => Promise<any>; | |||
|
|
|||
| checkBulkPermission( | |||
| checkBulkPermission<E extends object>( | |||
There was a problem hiding this comment.
There should probably be {entryId: string} not object
But we have some usages where entity type is {entryId?: string}
stepanenkoxx
commented
Dec 28, 2024
| checkWorkbookPermissionById({ | ||
| ctx, | ||
| workbookId, | ||
| permission: WorkbookPermission.View, |
There was a problem hiding this comment.
Or it must be like this?
permission: isEnabledFeature(ctx, Feature.UseLimitedView)
? WorkbookPermission.LimitedView
: WorkbookPermission.View,
upd. added flag check
stepanenkoxx
commented
Jan 13, 2025
imsitnikov
requested changes
Jan 13, 2025
imsitnikov
requested changes
Jan 17, 2025
imsitnikov
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.