new controllers for workbooks #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepanenkoxx
commented
Jan 17, 2025
| @@ -24,7 +24,9 @@ const schema = workbookModel.schema | |||
| ) | |||
| .describe('Workbook instance'); | |||
|
|
|||
| const format = (data: WorkbookInstance): z.infer<typeof schema> => { | |||
| export type WorkbookInstanceResponseModel = z.infer<typeof schema>; | |||
There was a problem hiding this comment.
think we must always store z.infer in separate types
this makes it possible to read types in a more familiar way than zod schemas
stepanenkoxx
requested review from
jhoncool,
imsitnikov,
Sergey-weber and
sjorobekov
imsitnikov
requested changes
Jan 19, 2025
imsitnikov
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.