Fix regex check for column name #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sicarul ! Thanks for contributing! Can you add a test for a single character column? I think since it's not a very common case, if that test isn't there, a regression may happen. |
|
@awm33 sorry, just saw your comment, will get to it |
|
@awm33 I've added the test, however i am not able to get almost any tests passing, most fail for me, including the one i added, i'm not sure what's going on. |
|
Sorry i'll have to open a new PR to switch out the branch, my bad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current regex check fails for single-character columns (I created a tap with a variable called "X"), please review at your earliest convenience, thanks!