CNDB-11118 return null serializer if response verb is null #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtgrabowski
force-pushed
the
CNDB-11118
branch
from
6420124
to
0bb6918
Compare
jtgrabowski
changed the base branch from
august-release-hotfix-cndb-10596
to
main
aymkhalil
reviewed
Oct 17, 2024
| @Test | ||
| public void testInternalResponseNullSerializer() throws Exception | ||
| { | ||
| depractedResponsesShouldReturnNullSerializer(Verb.INTERNAL_RSP); |
aymkhalil
reviewed
Oct 17, 2024
driftx
reviewed
Oct 17, 2024
| <In,Out> IVersionedAsymmetricSerializer<In, Out> responseSerializer(long id, InetAddressAndPort peer) | ||
| { | ||
| CallbackInfo info = get(id, peer); | ||
| return info == null ? null : info.responseVerb.serializer(); | ||
| return info == null || info.responseVerb == null ? null : info.responseVerb.serializer(); |
There was a problem hiding this comment.
I think it would be good to have a comment here to explain why this is being done.
jtgrabowski
force-pushed
the
CNDB-11118
branch
from
5c0c610
to
5226175
Compare
|
Thank you, I applied the review remarks.
This would mean opening access to a bunch of methods. I decided against it with this implementation. |
aymkhalil
approved these changes
Oct 18, 2024
jtgrabowski
force-pushed
the
CNDB-11118
branch
from
5226175
to
0df5f8a
Compare
response verb is null for deprecated REQUEST_RSP and INTERNAL_RSP. info.responseVerb.serializer() caused NullPointerExceptions. The null serializer is later gracefully handled in deserializePayloadPre40.
jtgrabowski
force-pushed
the
CNDB-11118
branch
from
0df5f8a
to
35eb670
Compare
|
❌ Build ds-cassandra-pr-gate/PR-1328 rejected by Butler1 new test failure(s) in 2 builds Found 1 new test failures
Found 11 known test failures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
response verb is null for deprecated REQUEST_RSP and INTERNAL_RSP. info.responseVerb.serializer() caused NullPointerExceptions.
The null serializer is later gracefully handled in deserializePayloadPre40.