Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNDB-11574 main-5.0: Fix VectorCompressionTest.testBert #1401

Draft
wants to merge 3 commits into
base: main-5.0
Choose a base branch
from

Conversation

adelapena
Copy link

For now, improve assertions to be a bit more informative and increase the timeout of the waiting for the index build.

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits

@adelapena adelapena marked this pull request as draft November 1, 2024 17:41
@adelapena adelapena self-assigned this Nov 1, 2024
Copy link

sonarcloud bot commented Nov 4, 2024

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1401 rejected by Butler


7 new test failure(s) in 1 builds
See build details here


Found 7 new test failures

Test Explanation Branch history Upstream history
t.TestCqlshUnicode.test_unicode_desc failing 🔴
t.TestCqlshUnicode.test_unicode_identifier failing 🔴
...adCommitLogAndSSTablesWithDroppedColumnTestCC40 failing 🔴
...adCommitLogAndSSTablesWithDroppedColumnTestCC50 failing 🔴
...oadCommitLogAndSSTablesWithDroppedColumnTestDSE failing 🔴
...thRestartTest.testReadingValuesOfDroppedColumns failing 🔴
...rrorsTest.testNoSuchRepairSessionAnticompaction failing 🔴

No known test failures found

@ekaterinadimitrova2
Copy link
Collaborator

I prefer the new logging, which also shows us the exact number of SSTables, and not just a single 1.
I was wondering if you tried the Jenkins multiplexer when you mentioned this was not reproducible. Does it work? I haven't tried the multiplexer myself. If you haven't tried that one, maybe we should do it?

Copy link
Collaborator

@ekaterinadimitrova2 ekaterinadimitrova2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not moved to ready for review but the patch is identical to the main patch, we have the repeated runs posted on the actual GH issues showing the flakiness is clean so I approve it to be committed after PR gate approves too. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants