Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multiline strings #156

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Conversation

filipecaixeta
Copy link
Contributor

Zookeeper has a yaml zookeeper-metadata.yaml that contains multiline string fields.
You will see something like this in that file

args:
  - >
    bin/pulsar initialize-cluster-metadata \

The problem with this is that the main library in Go for parsing yaml contains a bug and it is not able to generate the yaml files correctly.

I'm using Kustomize to deploy my helm charts (which uses that yaml library) and that is breaking the deployment.

Yaml also has another syntax for multiline string that works just fine

args:
  - |
    bin/pulsar initialize-cluster-metadata \

kafkaesque-io/pulsar-helm-chart#92

Copy link
Member

@michaeljmarshall michaeljmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution @filipecaixeta.

The test failed for reasons unrelated to this PR. Instead of rebasing, I tested this on my local machine and verified that it works as expected.

@michaeljmarshall michaeljmarshall merged commit 090b6a8 into datastax:master Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants