perf nitpick (#146)

datastax · May 13, 2024 · 0062dfd · 0062dfd
1 parent 1f02bf3
commit 0062dfd
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/pulsar-jms-filters/src/main/java/com/datastax/oss/pulsar/jms/selectors/JMSFilter.java b/pulsar-jms-filters/src/main/java/com/datastax/oss/pulsar/jms/selectors/JMSFilter.java
@@ -311,11 +311,16 @@ private static String getJmsSelectorOnSubscription(Subscription subscription) {
   }
 
   private SelectorSupport parseSelector(String jmsSelector) {
+    // null returned by SelectorSupport.build in computeIfAbsent won't be cached
+    // and in such cases it is better to not avoid the calls/synchronization there.
+    if (jmsSelector == null || jmsSelector.isEmpty()) {
+      return null;
+    }
     return selectors.computeIfAbsent(
         jmsSelector,
         s -> {
           try {
-            return SelectorSupport.build(s, !s.isEmpty());
+            return SelectorSupport.build(s, true);
           } catch (JMSException err) {
             log.error("Cannot parse selector {}", s, err);
             return null;