Added null checks to fix NPEs uncovered during testing #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-streamlio
changed the title
eolivelli
requested changes
Aug 2, 2023
| @@ -1095,7 +1099,9 @@ void acknowledgeInternal() throws JMSException { | |||
| return; | |||
| } | |||
| try { | |||
| consumer.acknowledge(receivedPulsarMessage, this, pulsarConsumer); | |||
| if (consumer != null) { | |||
| consumer.acknowledge(receivedPulsarMessage, this, pulsarConsumer); | |||
There was a problem hiding this comment.
in this case we should throw an IllegalStateException here.
how did you see an error here ?
There was a problem hiding this comment.
I suspected that an IllegalStateException was the better approach, so I can make that change. As for how I ended up here, I am still trying to figure that out, but I suspect it has something to do with not closing the PulsarSession and/or PulsarConnection object between calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found two separate locations in which an internal variable is referenced before checking to see is it is null or not. Both of these missing checks resulted in NullPointerExceptions during testing.