Upgrade Pulsar client (3.2.2) and fix JMS priority on consumer side using Pulsar 3.x #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
approved these changes
Apr 8, 2024
nicoloboschi
changed the title
eolivelli
approved these changes
Apr 8, 2024
...jms/src/main/java/com/datastax/oss/pulsar/jms/MessagePriorityGrowableArrayBlockingQueue.java
Outdated
Show resolved
Hide resolved
...jms/src/main/java/com/datastax/oss/pulsar/jms/MessagePriorityGrowableArrayBlockingQueue.java
Show resolved
Hide resolved
...jms/src/main/java/com/datastax/oss/pulsar/jms/MessagePriorityGrowableArrayBlockingQueue.java
Outdated
Show resolved
Hide resolved
pulsar-jms/src/main/java/com/datastax/oss/pulsar/jms/PulsarConnectionFactory.java
Show resolved
Hide resolved
nicoloboschi
changed the title
nicoloboschi
changed the title
|
TCK Failure (suite with server side filters) `FAILED........com/sun/ts/tests/jms/core20/jmscontexttopictests/Client.java#createSharedDurableConsumerTest1_from_standalone`` TCK failure (suite with client side filters)
|
eolivelli
requested changes
Apr 9, 2024
| @@ -81,7 +81,7 @@ public void testAUTO_ACKNOWLEDGE() throws Exception { | |||
| } | |||
|
|
|||
| try (MessageConsumer consumer = session.createConsumer(destination); ) { | |||
| assertEquals("foo", consumer.receive().getStringProperty("test")); | |||
| assertEquals("foo", consumer.receive(com.datastax.oss.pulsar.jms.utils.PulsarCluster.DEFAULT_RECEIVE_TIMEOUT).getStringProperty("test")); | |||
There was a problem hiding this comment.
This is changing the test, why ?
receive() is different than receive(timeout)
eolivelli
reviewed
Apr 9, 2024
| @@ -92,12 +98,12 @@ public void testPulsar211Transactions() throws Exception { | |||
|
|
|||
| @Test | |||
| public void testPulsar3Transactions() throws Exception { | |||
| test("apachepulsar/pulsar:3.0.0", true); | |||
| test("apachepulsar/pulsar:3.2.2", true); | |||
There was a problem hiding this comment.
3.2.2 is buggy, maybe we can use 3.2.1 if tests don't pass
eolivelli
reviewed
Apr 9, 2024
| @@ -106,11 +112,22 @@ public void testLunaStreaming210Transactions() throws Exception { | |||
| test(LUNASTREAMING, true); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testLunaStreaming31Transactions() throws Exception { | |||
| // waiting for Apache Pulsar 2.10.1, in the meantime we use Luna Streaming 2.10.0.x | |||
There was a problem hiding this comment.
we can drop this comment
This reverts commit 1f1776b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other notes: