Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tlsEnabled check for non-Tls serviceUrl check #198

Closed
wants to merge 1 commit into from
Closed

add tlsEnabled check for non-Tls serviceUrl check #198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1386,7 +1386,7 @@ public PulsarAdmin getClusterPulsarAdmin(String cluster, Optional<ClusterData> c
if (isTlsEnabled && StringUtils.isEmpty(data.getServiceUrlTls())) {
throw new IllegalArgumentException("serviceUrlTls is empty, brokerClientTlsEnabled: "
+ isTlsEnabled);
} else if (StringUtils.isEmpty(data.getServiceUrl())) {
} else if (!isTlsEnabled && StringUtils.isEmpty(data.getServiceUrl())) {
throw new IllegalArgumentException("serviceUrl is empty, brokerClientTlsEnabled: " + isTlsEnabled);
}
String adminApiUrl = isTlsEnabled ? data.getServiceUrlTls() : data.getServiceUrl();
Expand Down
Loading