Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NoSQLBench version to leverage the latest 5.21.1 #114

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Update NoSQLBench version to leverage the latest 5.21.1 #114

wants to merge 6 commits into from

Conversation

msmygit
Copy link
Contributor

@msmygit msmygit commented Jun 6, 2024 •
edited
Loading

  • Updates minor documentation items.
  • Leverages NoSQLBench to the latest 5.21.x version.
  • Adds dependabot that will help keep the GHA runner versions up to date so as to avoid warnings like as below,
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, test-summary/action@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

@msmygit msmygit marked this pull request as ready for review June 6, 2024 14:18
@msmygit msmygit force-pushed the main branch 2 times, most recently from 15efc87 to 957d8a6 Compare June 6, 2024 16:08
@msmygit msmygit force-pushed the main branch 2 times, most recently from 323fdd3 to 370b467 Compare July 18, 2024 19:10
grighetto
grighetto reviewed Jul 18, 2024
View reviewed changes
compose/nosqlbench-entrypoint.sh
hosts=zdm_tests_origin \
localdc=datacenter1 \
-v
#echo "Running NoSQLBench VERIFY job on ORIGIN"
Copy link
Collaborator

@grighetto grighetto Jul 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without the VERIFY step, this test is pretty much useless because this is what actually compares the stored data against the pseudo-random generated data.
I don't have the context why the NB update is happening in this PR (if it's for some new feature or compatibility with newer C* versions), but if we could still run the old NB with the verify step in addition to this until it's support in the latest NB version, I think it would be ideal.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood. NB 5.21 doesnt support verify feature yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joao-r-reis joao-r-reis joao-r-reis left review comments

@grighetto grighetto grighetto left review comments

@alicel alicel Awaiting requested review from alicel alicel is a code owner

@absurdfarce absurdfarce Awaiting requested review from absurdfarce absurdfarce is a code owner

@weideng1 weideng1 Awaiting requested review from weideng1 weideng1 is a code owner

@lukasz-antoniak lukasz-antoniak Awaiting requested review from lukasz-antoniak lukasz-antoniak is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msmygit @grighetto @joao-r-reis