Add config for controlling node ip resolution ordering #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mini-ninja-64
requested review from
joao-r-reis,
alicel,
grighetto,
absurdfarce,
weideng1 and
lukasz-antoniak
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
During node discovery, when ZDM proxy finds an entry in
system.peersandsystem.localit currently will always prefer node IP addresses returned bysystem.local. Some Cassandra implementations handlesystem.local&system.peertables differently, when thesystem.peertable contains ALL nodes in the cluster and the ip addresses fromsystem.localare invalid or should not be used then zdm-proxy will currently not work.This PR adds 2 new config properties (both defaulting to true, to maintain backwards compatability):
OriginPreferIpFromSystemLocal- Sets origin clusters to prefer IP address fromsystem.localTargetPreferIpFromSystemLocal- Sets target clusters to prefer IP address fromsystem.localThese can be used to control the resolution order of IP addresses and would allow for DataStax customers to better migrate from other Cassandra providers.
I am putting this PR out in its current form as an initial conversation starter, I am more than happy to add test coverage for this change, or make other changes, if it is a feature DataStax approves of.