Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bruker DIFFRAC.EVA xy FileType as diffrac-eva-xy #18

Merged
merged 2 commits into from
Oct 19, 2024

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Oct 17, 2024

This PR adds Bruker DIFFRAC.EVA, as described in the registry entry.

It stuffs some metadata in the header in a slightly annoying way, and is otherwise the same as a normal xy file:

'Id: "" Comment: "" Operator: "Emmy Noether" Anode: "Cu" Scantype: "Coupled TwoTheta/Theta" TimePerStep: "96"'
1.0000 2.00000

@ml-evs ml-evs marked this pull request as ready for review October 17, 2024 14:09
@PeterKraus
Copy link
Contributor

Do you maybe want to add a generic-xy filetype into this PR too and use the base_formats to refer to it?

@ml-evs
Copy link
Member Author

ml-evs commented Oct 18, 2024

I'm not sure, its not like .xy is particularly well defined either...

@PeterKraus
Copy link
Contributor

Well, it depends. It's a format the same way generic-csv would be a format. Lines starting with # are comments, empty lines are skipped, everything else should be x.xxx y.yyy (whitespace separated) otherwise it's not a valid generic-xy.

@ml-evs
Copy link
Member Author

ml-evs commented Oct 19, 2024

Well, it depends. It's a format the same way generic-csv would be a format. Lines starting with # are comments, empty lines are skipped, everything else should be x.xxx y.yyy (whitespace separated) otherwise it's not a valid generic-xy.

That's kind of the problem, this eva diffract format already breaks the comment rule (which is why I had to add special support for it in datalab). I get that it might be useful though, e.g., at the very base of it it would be nice to distinguish between plain text or binary formats based on this generic format

@PeterKraus PeterKraus merged commit b612462 into main Oct 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants