Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom CSS classes in showProveanceGraphNotFoundDialog #238

Merged
merged 1 commit into from
Nov 12, 2019
Merged

Allow custom CSS classes in showProveanceGraphNotFoundDialog #238

merged 1 commit into from
Nov 12, 2019

Conversation

lehnerchristian
Copy link

@lehnerchristian lehnerchristian commented Oct 30, 2019 •
edited by thinkh
Loading

Issue of this PR: phovea/phovea_ui#75

Requires phovea/phovea_ui#76

@thinkh thinkh changed the title adapted typings and added custom CSS classes to showProveanceGraphNot… Allow custom CSS classes in showProveanceGraphNotFoundDialog Oct 31, 2019
thinkh
thinkh approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Waiting for phovea_ui PR to merge.

@thinkh thinkh merged commit 620ef89 into develop Nov 12, 2019
@thinkh thinkh deleted the clehner/phovea_ui_75_extensible_dialog branch November 12, 2019 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkh thinkh thinkh approved these changes

Assignees

@thinkh thinkh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lehnerchristian @thinkh